Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize prost dependency via ToVec trait #997

Closed
Farhad-Shabani opened this issue Dec 1, 2023 · 1 comment · Fixed by #998 or #1000
Closed

Minimize prost dependency via ToVec trait #997

Farhad-Shabani opened this issue Dec 1, 2023 · 1 comment · Fixed by #998 or #1000
Assignees
Labels
A: breaking Admin: breaking change that may impact operators O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Summary

The prost should ideally be only a dependency of the *-types crates, as it essentially facilitates back and forth between domain and proto types.

Proposal

We can introduce a ToVec trait and blanket implement it for types that implement prost::Message. This modification would enable the removal of the prost from all the module-level implementations.

@Farhad-Shabani Farhad-Shabani added the O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding label Dec 1, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Dec 1, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.49.0 milestone Dec 1, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Dec 1, 2023
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Dec 1, 2023
@Farhad-Shabani
Copy link
Member Author

Farhad-Shabani commented Dec 1, 2023

Further investigation revealed we even can move away from prost in all the *-types crates and manage prost only in the ibc-pritmitves. This improvement decouples our errors from prost and paves the way for refactoring our error-handling system through this issue: #270

@Farhad-Shabani Farhad-Shabani self-assigned this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: breaking Admin: breaking change that may impact operators O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Projects
Status: Done
1 participant