Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger and event emitter methods should return Result #859

Closed
Tracked by #861
Farhad-Shabani opened this issue Sep 6, 2023 · 0 comments · Fixed by #860
Closed
Tracked by #861

logger and event emitter methods should return Result #859

Farhad-Shabani opened this issue Sep 6, 2023 · 0 comments · Fixed by #860
Assignees
Labels
A: breaking Admin: breaking change that may impact operators
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Context

Hosts implementing ibc-rs, In certain situations:

  • May need to convert an IbcEvent or a log message into a local event or log type specific to their environment. However, this conversion process may encounter failures.
  • Likewise, when attempting to store events or logs, there may be instances where the storage operation results in an error.

To accommodate hosts in handling failures according to their preferences in either of these scenarios,emit_ibc_event and log_message methods should return the Result<(), ContextError> type.

@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Sep 6, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Sep 7, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.45.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: breaking Admin: breaking change that may impact operators
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant