Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer contexts: split send_coins_*() methods #837

Closed
Tracked by #554 ...
plafer opened this issue Aug 22, 2023 · 0 comments · Fixed by #836
Closed
Tracked by #554 ...

Transfer contexts: split send_coins_*() methods #837

plafer opened this issue Aug 22, 2023 · 0 comments · Fixed by #836
Assignees
Labels
A: breaking Admin: breaking change that may impact operators
Milestone

Comments

@plafer
Copy link
Contributor

plafer commented Aug 22, 2023

To escrow/unescrow tokens, we currently

  1. get the escrow address using get_escrow_address()
  2. use send_coins_execute() to/from this escrow address

A better API would replace these functions with:

  1. escrow_coins_{validate,execute}()
  2. unescrow_coins_{validate,execute}()

These names are more descriptive, and tell the implementor if they are currently escrowing or unescrowing tokens, which in some cases is necessary information (e.g. in the Sovereign SDK).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: breaking Admin: breaking change that may impact operators
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants