Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICS07] Client/ConsensusState bytes for upgrade_client validation should be derived from prost #672

Closed
Farhad-Shabani opened this issue May 10, 2023 · 0 comments · Fixed by #673
Assignees
Labels
A: bug Admin: something isn't working
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Bug Summary

verify_upgrade_client method encodes (e.g. here) upgraded_client/cons_state incorrectly.

Proposal

We should instead use prost::Message:

        let mut client_state_value = Vec::new();
        upgraded_client_state
            .encode(&mut client_state_value)
            .map_err(ClientError::Encode)?;

Version

v0.40.0

@Farhad-Shabani Farhad-Shabani added the A: bug Admin: something isn't working label May 10, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this May 10, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.41.0 milestone May 11, 2023
@Farhad-Shabani Farhad-Shabani changed the title Client/ConsensusState bytes for upgrade_client validation should be derived from prost [ICS07] Client/ConsensusState bytes for upgrade_client validation should be derived from prost May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant