Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICS03][ICS04] Refactor and fix version validation in connection and channel handshakes #625

Closed
Tracked by #233
Farhad-Shabani opened this issue Apr 14, 2023 · 1 comment · Fixed by #626
Closed
Tracked by #233

[ICS03][ICS04] Refactor and fix version validation in connection and channel handshakes #625

Farhad-Shabani opened this issue Apr 14, 2023 · 1 comment · Fixed by #626
Assignees
@Farhad-Shabani
Labels
A: breaking Admin: breaking change that may impact operators A: bug Admin: something isn't working O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding O: reliability Objective: cause to improve trustworthiness and consistent performing
Milestone
v0.38.0

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Apr 14, 2023 •
edited
Loading

Summary

Part of #233

Found confusing validation codebase around Version type, in particular in places we call contains() and unsure if checks are done correctly. Also, there is a bit higher processing cost within pick_version method.
Streamlining and maintaining the code will ensure all validation steps are completed.
@Farhad-Shabani Farhad-Shabani added O: reliability Objective: cause to improve trustworthiness and consistent performing O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding labels Apr 14, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Apr 14, 2023
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Apr 20, 2023
@plafer plafer added the A: bug Admin: something isn't working label Apr 21, 2023
@plafer
Copy link
Contributor

plafer commented Apr 21, 2023

Our version check in connection handshakes is incorrect. See proper algorithm in ibc-go.

@Farhad-Shabani Farhad-Shabani changed the title [ICS03] Streamline Version validation codebase [ICS03][ICS04] Refactor and fix version validation in connection and channel handshakes Apr 21, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Apr 25, 2023
Closed
5 tasks
@Farhad-Shabani Farhad-Shabani self-assigned this Apr 25, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.38.0 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Farhad-Shabani Farhad-Shabani

Labels
A: breaking Admin: breaking change that may impact operators A: bug Admin: something isn't working O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding O: reliability Objective: cause to improve trustworthiness and consistent performing
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.38.0
Development

Successfully merging a pull request may close this issue.

Refactor and fix version validation in connection and channel handshakes cosmos/ibc-rs
2 participants
@plafer @Farhad-Shabani