-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Add a Signer
validation method to include host-specific checks for validate()
processes
#619
Comments
Should this be included in #233 as well? |
Why does the IBC messages are self-authenticating, the relayer is not a trusted part of the system design. They're authenticated by the counterparty chain, not the relayer who happened to send the transaction. The current domain types in |
Sounds like we are on the same page. Maybe, I didn't phrase this issue well. To achieve this, a validation check:
This way, we are sure that all the needed validation steps are being considered. None are being missed. Besides, the boundaries between the checks that should be carried out by IBC-rs and those that should be handled by hosts are clearly defined.
Given the above points, yes. To me, it seems more appropriate to drop this too and leave it to the hosts. Hopefully, I didn't miss anything, but if so, let me know. |
Signer
validationSigner
validation method to include host-specific checks for validate()
processes
I think it's better to handle this separately |
ibc-go ensures that the |
Problem Statement
IBC messages contain a
Singer
field, which have not yet been used in any operations of IBC-rs, but should be checked and disallowed for a counterfactual signing. So, from the IBC module standpoint, we get sure that once a message passes the validation phase, all the fields are valid.Proposal
It can be accomplished by exposing an additional interface through
ValidationContext
that provides a room for hosts to verify signer accounts as needed.The text was updated successfully, but these errors were encountered: