Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MsgTransfer struct #567

Closed
plafer opened this issue Mar 27, 2023 · 0 comments · Fixed by #568
Closed

Improve MsgTransfer struct #567

plafer opened this issue Mar 27, 2023 · 0 comments · Fixed by #568
Assignees
@plafer
Labels
A: breaking Admin: breaking change that may impact operators
Milestone
v0.37.0

Comments

@plafer
Copy link
Contributor

plafer commented Mar 27, 2023

Our current MsgTransfer struct has 2 flaws.

  1. In our conversion from the raw type, we don't fully convert the token field. The conversion is instead completed in the send_transfer function.
  2. ICS-20: add memo field #559 requires us to add a memo field to both MsgTransfer and PacketData. This is not DRY. Instead of copy/pasting a subset of fields from MsgTransfer to PacketData, MsgTransfer should instead contain a PacketData field.

Note that this is an example of us changing a domain type, which currently requires a breaking change (#324).
@plafer plafer self-assigned this Mar 27, 2023
@plafer plafer mentioned this issue Mar 27, 2023
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Mar 27, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.37.0 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plafer plafer

Labels
A: breaking Admin: breaking change that may impact operators
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.37.0
Development

Successfully merging a pull request may close this issue.

Improve MsgTransfer cosmos/ibc-rs
2 participants
@plafer @Farhad-Shabani