Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Send + Sync requirement on Module trait #480

Closed
Tracked by #431
plafer opened this issue Feb 28, 2023 · 0 comments · Fixed by #481
Closed
Tracked by #431

Remove Send + Sync requirement on Module trait #480

plafer opened this issue Feb 28, 2023 · 0 comments · Fixed by #481
Assignees
@plafer
Labels
O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Milestone
v0.31.0

Comments

@plafer
Copy link
Contributor

plafer commented Feb 28, 2023

I believe historically that we put Send + Sync as a convenience to facilitate implementing the tendermint_abci::Application trait in basecoin-rs.

However, it is not strictly necessary, and is a blocker for Namada, whose transfer module contains a RefCell.
@plafer plafer added the O: usability Objective: aims to enhance user experience (UX) and streamline product usability label Feb 28, 2023
@plafer plafer added this to the v0.31.0 milestone Feb 28, 2023
@plafer plafer self-assigned this Feb 28, 2023
@plafer plafer mentioned this issue Feb 28, 2023
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani mentioned this issue Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plafer plafer

Labels
O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.31.0
Development

Successfully merging a pull request may close this issue.

Remove supertraits cosmos/ibc-rs
1 participant
@plafer