Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS-20: Acknowledgement::Error is incompatible with ibc-go #371

Closed
plafer opened this issue Jan 23, 2023 · 2 comments
Closed

ICS-20: Acknowledgement::Error is incompatible with ibc-go #371

plafer opened this issue Jan 23, 2023 · 2 comments
Assignees
Labels
A: bug Admin: something isn't working A: urgent Admin: high priority issue O: logic Objective: aims for better implementation logic

Comments

@plafer
Copy link
Contributor

plafer commented Jan 23, 2023

Bug Summary

Our Acknowledgement::Error once serialized is different from ibc-go.

Details

Compare ibc-go output with our AsRef<u8> Error variant.

Version

v0.27.0

@plafer plafer added A: bug Admin: something isn't working A: urgent Admin: high priority issue O: logic Objective: aims for better implementation logic labels Jan 23, 2023
@plafer plafer self-assigned this Jan 23, 2023
@plafer
Copy link
Contributor Author

plafer commented Jan 25, 2023

Note that the error output needs to be of the form {"error":"<whatever>"} to be compatible with all versions of ibc-go.

ibc-go did in fact change its error output:

  • v3.0.0: {"error":"cannot unmarshal ICS-20 transfer packet data"}

  • v5.0.0: {"error":"ABCI code: %d: cannot unmarshal ICS-20 transfer packet data"}

@plafer
Copy link
Contributor Author

plafer commented Jan 25, 2023

I will close as duplicate of #369, and fix both the success and error scenarios with that issue.

@plafer plafer closed this as completed Jan 25, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: Support Anoma's onboarding efforts, Fix known bugs and issues Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working A: urgent Admin: high priority issue O: logic Objective: aims for better implementation logic
Projects
Status: Done
Development

No branches or pull requests

2 participants