Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ICS 721: NFT transfer on ibc-rs #346

Closed
5 tasks
blasrodri opened this issue Jan 11, 2023 · 3 comments · Fixed by #1020 or #1053
Closed
5 tasks

Implement ICS 721: NFT transfer on ibc-rs #346

blasrodri opened this issue Jan 11, 2023 · 3 comments · Fixed by #1020 or #1053

Comments

@blasrodri
Copy link
Contributor

blasrodri commented Jan 11, 2023

Summary

Implement iCS 721: NFT transfer on ibc-rs

Problem Definition

At Composable, we are currently finishing up our Centauri Bridge, which will connect the Polkadot with Cosmos. It is important
for us to be able to support NFT transfers to give those chains that are using this feature through IBC.

Proposal

Ideally follow the spec and the reference implementation written in go, and a reference implementation in CosmWasm

Acceptance Criteria

Happy path

NFT being transferred from chain A to B, and then back from B to A.

Less happy path

NFT transfer timing out, and not being transferred to chain B from A.
NFT transfer succeeding from A to B, but timing out from B to A.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@blasrodri blasrodri changed the title Implement iCS 721: NFT transfer on ibc-rs Implement ICS 721: NFT transfer on ibc-rs Jan 11, 2023
@plafer
Copy link
Contributor

plafer commented Jan 11, 2023

Thank you for opening this issue. Would someone from Composable have the capacity to implement this? Ideally, we would also have a (brief) ADR outlining the architecture of the module so that we can agree on the general architecture before you start implementing.

Also please note that with #322, the Module API will be changed slightly. However the merge conflicts shouldn't be that bad (depending on when you start implementing).

@blasrodri
Copy link
Contributor Author

Thank you for opening this issue. Would someone from Composable have the capacity to implement this? Ideally, we would also have a (brief) ADR outlining the architecture of the module so that we can agree on the general architecture before you start implementing.

Also please note that with #322, the Module API will be changed slightly. However the merge conflicts shouldn't be that bad (depending on when you start implementing).

Pleasure :)

Our goal is to do the bulk of the work, and get from the core maintainers support on the review side + architecture. We'd have to port these changes into our own fork, since we aren't currently using the canonical ibc-rs. But I felt it was a good feature to collaborate and potentially avoid duplication of efforts.

What do you think?

@plafer
Copy link
Contributor

plafer commented Jan 11, 2023

Yes that sounds great to me 😀

@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Feb 2, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: Shepherd open source contributions from users, v0.28.0 Feb 3, 2023
@adizere adizere linked a pull request Jan 5, 2024 that will close this issue
7 tasks
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants