Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codec and borsh for ics04_channel::msgs::Acknowledgement and events::ModuleEvent #303

Closed
5 tasks
DaviRain-Su opened this issue Dec 19, 2022 · 0 comments · Fixed by #312
Closed
5 tasks

Add codec and borsh for ics04_channel::msgs::Acknowledgement and events::ModuleEvent #303

DaviRain-Su opened this issue Dec 19, 2022 · 0 comments · Fixed by #312

Comments

@DaviRain-Su
Copy link
Contributor

Summary

Problem Definition

Because these types are of events in Ibc, the definition of events in substrate development is needed for parity-scale-codec implementation, borsh should be similar in contract development. Here are the two types that were not implemented in the last pr's #273 legacy

Proposal

Acceptance Criteria

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix add codec and borsh for Acknowledgement , Receipt and ModuleEvent octopus-network/ibc-rs
1 participant
@DaviRain-Su