Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public PrefixedDenom inner type and add as_str func for BaseDenom #161

Merged
merged 7 commits into from
Oct 14, 2022
Merged

Public PrefixedDenom inner type and add as_str func for BaseDenom #161

merged 7 commits into from
Oct 14, 2022

Conversation

DaviRain-Su
Copy link
Contributor

@DaviRain-Su DaviRain-Su commented Oct 11, 2022 •
edited by hu55a1n1
Loading

Closes: #176

Add some need help function.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@DaviRain-Su DaviRain-Su changed the title add some function Add getter function of Amount, PrefixedDenom and add Ics20Error to Ics04Error Oct 11, 2022
@plafer plafer mentioned this pull request Oct 12, 2022
Closed
hu55a1n1
hu55a1n1 suggested changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@hu55a1n1 hu55a1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @DaviRain-Su!

crates/ibc/src/applications/transfer/amount.rs Outdated Show resolved Hide resolved
crates/ibc/src/applications/transfer/amount.rs Outdated Show resolved Hide resolved
@DaviRain-Su DaviRain-Su changed the title Add getter function of Amount, PrefixedDenom and add Ics20Error to Ics04Error Add getter function of PrefixedDenom Oct 12, 2022
@DaviRain-Su DaviRain-Su changed the title Add getter function of PrefixedDenom Public PrefixedDenom inner type and add as_str func for BaseDenom Oct 14, 2022
hu55a1n1
hu55a1n1 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@hu55a1n1 hu55a1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@hu55a1n1 hu55a1n1 merged commit d17e090 into cosmos:main Oct 14, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this pull request Nov 4, 2023
@faddat @crodriguezvega
chore: lint ics23 golang code (cosmos#161)
5f9fbd8 
* lint

* update ci config

* remove unused code

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
@DaviRain-Su
Public PrefixedDenom inner type and add as_str func for BaseDenom (#161)
1a3fb55 
* add some function

* add getter function for BaseDenom

* remove ics20transfer from ics04Error and pub ics20 Amount inner typo

* revert pub Amount inner type

* Create 161-add-getter-function-of-prefixeddenom.md

* Public PrefixedDenom Inner type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plafer plafer plafer left review comments

@hu55a1n1 hu55a1n1 hu55a1n1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide public access to PrefixedDenoms trace path and denom
3 participants
@DaviRain-Su @plafer @hu55a1n1