Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up inefficient String variants in error types #1346

Closed
seanchen1991 opened this issue Sep 18, 2024 · 0 comments · Fixed by #1347 or #1350
Closed

Clean up inefficient String variants in error types #1346

seanchen1991 opened this issue Sep 18, 2024 · 0 comments · Fixed by #1347 or #1350
Assignees
Labels
S: errors Scope: related to error handlings
Milestone

Comments

@seanchen1991
Copy link
Contributor

Feature Summary

Application and client-specific errors (like those in 07-tendermint) often get converted to strings and end up in variants like Other or ClientSpecific within lower-level error enums. This approach not only leads to large memory allocations but also makes it difficult for hosts to traverse the error structure to extract or check the specific data they need. Instead, they are forced to parse these strings, which is cumbersome and inefficient.

Proposal

Clean up and/or consolidate these error variants such that their semantics give a better idea of the underlying error.

@seanchen1991 seanchen1991 self-assigned this Sep 18, 2024
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Sep 18, 2024
@seanchen1991 seanchen1991 moved this from 📥 To Do to 🏗️ In Progress in ibc-rs Sep 18, 2024
@seanchen1991 seanchen1991 added this to the 0.55.0 milestone Sep 18, 2024
@Farhad-Shabani Farhad-Shabani added the S: errors Scope: related to error handlings label Sep 20, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: errors Scope: related to error handlings
Projects
Status: Done
2 participants