Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HostError context within each module-level error type #1340

Closed
seanchen1991 opened this issue Sep 16, 2024 · 0 comments
Closed

Add HostError context within each module-level error type #1340

seanchen1991 opened this issue Sep 16, 2024 · 0 comments
Assignees
Milestone

Comments

@seanchen1991
Copy link
Contributor

Feature Summary

As we've defined and added the new HostError type into ibc-rs, a discrepancy has come about with how we've organized our errors at the top level. Specifically, the top-level error type contains module-level errors and then the HostError, which is not related to any one specific module. Instead, host errors, or errors that arise from any of the module-level handlers, can originate from any of the modules. Thus, it would be more appropriate to have a Host(HostError) variant within each of the module errors instead of in the top-level error type. This will incur duplication across our different error types, but in this case, the tradeoff of adding additional context that indicates a host-level error within a particular module justifies this duplication.

Proposal

Remove the Host(HostError) variant from the top-level HandlerError and add this variant to each of the module-level error types.

@seanchen1991 seanchen1991 added this to the 0.55.0 milestone Sep 16, 2024
@seanchen1991 seanchen1991 self-assigned this Sep 16, 2024
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Sep 16, 2024
@seanchen1991 seanchen1991 moved this from 📥 To Do to 🏗️ In Progress in ibc-rs Sep 17, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant