You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The packet, acknowledgement, and timeout messages are missing domain type implementations.
Proposal
Similarly with #105 (channel messages), we need to:
[] Add the From/TryFrom impls for all messages pertaining to packets and supporting structures where missing
[] Make sure tests are aligned wrt raw messages and test (de)serialization
[x] Split the msgs.rs file in per message modules -- this will be handled in #105 alongside all other ICS4 messages.
The text was updated successfully, but these errors were encountered:
adizere
changed the title
Todo: Packet implementation
Packet Domain Types
Nov 5, 2020
Problem
The packet, acknowledgement, and timeout messages are missing domain type implementations.
Proposal
Similarly with #105 (channel messages), we need to:
[] Add the From/TryFrom impls for all messages pertaining to packets and supporting structures where missing
[] Make sure tests are aligned wrt raw messages and test (de)serialization
[x] Split the msgs.rs file in per message modules -- this will be handled in #105 alongside all other ICS4 messages.
The text was updated successfully, but these errors were encountered: