Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded_path in ics07-tendermint was removed #1297

Closed
yito88 opened this issue Aug 5, 2024 · 0 comments · Fixed by #1298
Closed

upgraded_path in ics07-tendermint was removed #1297

yito88 opened this issue Aug 5, 2024 · 0 comments · Fixed by #1298
Labels
A: bug Admin: something isn't working
Milestone

Comments

@yito88
Copy link
Contributor

yito88 commented Aug 5, 2024

Bug Summary

I'm testing the client upgrade with Namada.
The upgraded_path was removed and the verification panicked.

Details

When the upgrade_path has only one, the first upgrade path was removed by upgrade_path.pop() and the next check for upgrade_path[0] panicked.

let mut upgrade_path = client_state.upgrade_path.clone();
if upgrade_path.pop().is_none() {
return Err(ClientError::ClientSpecific {
description: "cannot upgrade client as no upgrade path has been set".to_string(),
});
};
let upgrade_path_prefix = CommitmentPrefix::from(upgrade_path[0].clone().into_bytes());

Version

0.53.0

@yito88 yito88 mentioned this issue Aug 5, 2024
7 tasks
@seanchen1991 seanchen1991 changed the title upgraded_path in ics07-tendermint was removed upgraded_path in ics07-tendermint was removed Aug 5, 2024
@seanchen1991 seanchen1991 added this to the 0.54.0 milestone Aug 5, 2024
@seanchen1991 seanchen1991 added the A: bug Admin: something isn't working label Aug 5, 2024
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Aug 8, 2024
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants