Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS02/07 - Create and Update Client #128

Closed
ebuchman opened this issue Jul 19, 2020 · 3 comments
Closed

ICS02/07 - Create and Update Client #128

ebuchman opened this issue Jul 19, 2020 · 3 comments
Assignees

Comments

@ebuchman
Copy link
Member

ebuchman commented Jul 19, 2020

Re informalsystems/hermes#119. We already have the ICS07 msg types, so we should build out the ICS07 logic for processing those messages.

This can start using an abstract kv store, but it should ultimately leverage informalsystems/hermes#158

This logic is effectively light client logic from tendermint-rs, so it will likely intersect with ongoing work there.

We should also be thinking about this in the context of informalsystems/tendermint-rs#461 and the ongoing fork detection work.

This task should focus on CreateClient and UpdateClient methods.
See for example how it is implemented in the Cosmos SDK:

Relevants specs:

Relevant code in the Cosmos SDK:

@ebuchman ebuchman changed the title ICS02/07 - Client msgs and handlers ICS02/07 - Create and Update Client Jul 19, 2020
@adizere adizere self-assigned this Jul 24, 2020
@adizere
Copy link
Contributor

adizere commented Jul 28, 2020

Relevant discussion for the work on this issue: https://github.com/cosmos/ics/issues/456.

@ebuchman
Copy link
Member Author

So I believe a lot of this was done in informalsystems/hermes#197 but some stuff is still stubbed out. We can leave this open for now but @romac when you get back can you make a follow up issue with the specific items left todo

@ebuchman
Copy link
Member Author

@romac should we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants