-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline the release process #1226
Comments
Update: Sent an email to the crates.io team, their response was:
So one possible way to address the rate limit when performing a release with new sub-crates is to email the crates.io folks so that they can temporarily increase the limit. However, this is not really an ideal solution if it needs to be done on every new release. |
How many _new_ crates were you guys trying to release last time?
|
Just one, though it brought the total number of crates being published to 31. So that is a little confusing as far as why we hit the rate limit. |
Looking at it more closely, I'm not actually sure how we got this error now:
I don't actually see it in any of the CI runs in the commit history. The errors that caused the runs to fail were that we tried to publish a crate that was already published, and we had a dependency version mismatch. So maybe the crates.io rate limit isn't causing us issues. |
Hey @seanchen1991, the error is here I think it was on the deleted tag - so you don't see it anymore on the commit history. The error is from |
So it looks like there are multiple layers to the issue here as far as the rate limit is concerned. If we're publishing more than 30 existing crates, we'll hit both the crates.io rate limit as well as this check in We can ask the crates.io team to temporarily raise the 30 crate limit prior to performing a new release, which isn't great, but that also won't address the check in |
crate-ci/cargo-release#792 is now merged. We can update our release process with We can add the following lines in our [workspace.metadata.release]
rate-limit = { existing-packages = 40 } Also, we need to update our |
Feature Summary
The current
ibc-rs
release process is error-prone and flaky, especially on thecargo release
step. This is in large part due to the 30-crate rate limit for existing sub-crates;ibc-rs
now has more than that in its workspace. This requires us to first manually release leaf dependencies until we meet the 30-crate limit.Additionally, with the most recent 0.53.0 release, the
ibc-testkit
crate failed to be published due to it depending on theibc-client-tendermint-cw
crate, however, this crate was excluded from publishing to crates.io. The rest of the sub-crates were successfully published, but these last two crates needed to be published manually in order to complete the release.Proposal
@romac suggested asking the crates.io maintainers about whether they can raise the 30 crate rate limit for
ibc-rs
. Are there perhaps other ways to get around this issue that we could look into?The text was updated successfully, but these errors were encountered: