Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(ics20): PrefixedDenom is parsed with invalid ChannelId #1177

Closed
rnbguy opened this issue Apr 19, 2024 · 1 comment · Fixed by #1178
Closed

bug(ics20): PrefixedDenom is parsed with invalid ChannelId #1177

rnbguy opened this issue Apr 19, 2024 · 1 comment · Fixed by #1178
Assignees
@rnbguy
Labels
A: bug Admin: something isn't working
Milestone
0.52.0

Comments

@rnbguy
Copy link
Collaborator

rnbguy commented Apr 19, 2024

Bug Summary

Parsing transfer/channel-75/factory/stars16da2uus9zrsy83h23ur42v3lglg5rmyrpqnju4/dust to PrefixedDenom results in

  • transfer/channel-75/factory/stars16da2uus9zrsy83h23ur42v3lglg5rmyrpqnju4 as TracePath
  • dust as BaseDenom

Details

The parsed data should have:

  • transfer/channel-75 as TracePath
  • factory/stars16da2uus9zrsy83h23ur42v3lglg5rmyrpqnju4/dust as BaseDenom

Following ibc-go, we should validate the ChannelIds.

Version

v0.51.0

Reference

Fabien Penso reported this.
@rnbguy rnbguy self-assigned this Apr 19, 2024
@rnbguy rnbguy added the A: bug Admin: something isn't working label Apr 19, 2024
@rnbguy rnbguy mentioned this issue Apr 19, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Apr 19, 2024
@seanchen1991 seanchen1991 moved this from 📥 To Do to 🏗️ In Progress in ibc-rs Apr 19, 2024
@seanchen1991 seanchen1991 added this to the 0.52.0 milestone Apr 19, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnbguy rnbguy

Labels
A: bug Admin: something isn't working
Projects
ibc-rs
Status: ✅ Done
Milestone
0.52.0
Development

Successfully merging a pull request may close this issue.

fix(ics20): PrefixedDenom parsing cosmos/ibc-rs
3 participants
@rnbguy @seanchen1991 and others