fix: recursive call in connection State conversion to i32
#1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvja
changed the title
mina86
reviewed
Dec 18, 2023
Co-authored-by: Michal Nazarewicz <[email protected]> Signed-off-by: Dhruv D Jain <[email protected]>
Farhad-Shabani
approved these changes
Dec 18, 2023
Farhad-Shabani
changed the title
State conversion to i32
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1010 +/- ##
=======================================
Coverage 70.69% 70.70%
=======================================
Files 178 178
Lines 17870 17865 -5
=======================================
- Hits 12634 12631 -3
+ Misses 5236 5234 -2 ☔ View full report in Codecov by Sentry. |
Spent quite a while figuring out the vague |
Farhad-Shabani
added a commit
that referenced
this pull request
Dec 22, 2023
* fix state conversion recursive call * replace match with casting Co-authored-by: Michal Nazarewicz <[email protected]> Signed-off-by: Dhruv D Jain <[email protected]> * chore: add unclog * nit --------- Signed-off-by: Dhruv D Jain <[email protected]> Co-authored-by: Michal Nazarewicz <[email protected]> Co-authored-by: Farhad Shabani <[email protected]>
Farhad-Shabani
added a commit
that referenced
this pull request
Jan 2, 2024
* fix: packet sequence in Timeout handlers should be encoded in big-endian (#1004) * fix: encode package sequence into big endian bytes * Fix this issue in `to_vec` method. * fix: recursive call in connection `State` conversion to `i32` (#1010) * fix state conversion recursive call * replace match with casting Co-authored-by: Michal Nazarewicz <[email protected]> Signed-off-by: Dhruv D Jain <[email protected]> * chore: add unclog * nit --------- Signed-off-by: Dhruv D Jain <[email protected]> Co-authored-by: Michal Nazarewicz <[email protected]> Co-authored-by: Farhad Shabani <[email protected]> * Release v0.48.2 chore: update changelog + summary deps: bump versions to v0.48.2 --------- Signed-off-by: Dhruv D Jain <[email protected]> Co-authored-by: Yuanchao Sun <[email protected]> Co-authored-by: Dhruv D Jain <[email protected]> Co-authored-by: Michal Nazarewicz <[email protected]>
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* fix state conversion recursive call * replace match with casting Co-authored-by: Michal Nazarewicz <[email protected]> Signed-off-by: Dhruv D Jain <[email protected]> * chore: add unclog * nit --------- Signed-off-by: Dhruv D Jain <[email protected]> Co-authored-by: Michal Nazarewicz <[email protected]> Co-authored-by: Farhad Shabani <[email protected]>
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* fix: packet sequence in Timeout handlers should be encoded in big-endian (#1004) * fix: encode package sequence into big endian bytes * Fix this issue in `to_vec` method. * fix: recursive call in connection `State` conversion to `i32` (#1010) * fix state conversion recursive call * replace match with casting Co-authored-by: Michal Nazarewicz <[email protected]> Signed-off-by: Dhruv D Jain <[email protected]> * chore: add unclog * nit --------- Signed-off-by: Dhruv D Jain <[email protected]> Co-authored-by: Michal Nazarewicz <[email protected]> Co-authored-by: Farhad Shabani <[email protected]> * Release v0.48.2 chore: update changelog + summary deps: bump versions to v0.48.2 --------- Signed-off-by: Dhruv D Jain <[email protected]> Co-authored-by: Yuanchao Sun <[email protected]> Co-authored-by: Dhruv D Jain <[email protected]> Co-authored-by: Michal Nazarewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1009
Description
Since the conversion from
statetoi32causes a recursive call, it can be solved by matching the enum variants and returning the i32 for the respective variant.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.