-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement OnChanUpgradeAck on Controller Chain for interchain-accounts #5160
Implement OnChanUpgradeAck on Controller Chain for interchain-accounts #5160
Conversation
…ainaccounts' into cian/issue#5142-implement-onchanupgradetry-on-host-chain-for-interchainaccounts
…ainaccounts' into cian/issue#5142-implement-onchanupgradetry-on-host-chain-for-interchainaccounts
…ainaccounts' into cian/issue#5145-implement-onchanupgradeack-on-controller-chain-for-interchainaccounts
…ainaccounts' into cian/issue#5145-implement-onchanupgradeack-on-controller-chain-for-interchainaccounts
…hanupgradetry-on-host-chain-for-interchainaccounts
…hanupgradeack-on-controller-chain-for-interchainaccounts
…r-chain-for-interchainaccounts' of github.com:cosmos/ibc-go into cian/issue#5145-implement-onchanupgradeack-on-controller-chain-for-interchainaccounts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one requested change, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charleenfei for pushing this over the line! 🚀 And @chatton for getting this started!
…hanupgradeack-on-controller-chain-for-interchainaccounts
This PR will need type assertions on the If this is merged first I can update my PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you again, @chatton and @charleenfei.
modules/apps/27-interchain-accounts/controller/keeper/handshake_test.go
Outdated
Show resolved
Hide resolved
…hanupgradeack-on-controller-chain-for-interchainaccounts
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 04-channel-upgrades #5160 +/- ##
=======================================================
- Coverage 80.45% 80.37% -0.08%
=======================================================
Files 197 197
Lines 14927 14973 +46
=======================================================
+ Hits 12009 12035 +26
- Misses 2455 2474 +19
- Partials 463 464 +1
|
…hanupgradeack-on-controller-chain-for-interchainaccounts
7b076d1
to
05f7685
Compare
Description
(this one is also r4r after
OnChanUpgradeTry
for host is merged)Review after #5140 and #5142
closes: #5145
ref: the spec
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.