Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OnChanUpgradeAck on Controller Chain for interchain-accounts #5160

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Nov 22, 2023

Description

(this one is also r4r after OnChanUpgradeTry for host is merged)

Review after #5140 and #5142

closes: #5145

ref: the spec


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

…ainaccounts' into cian/issue#5142-implement-onchanupgradetry-on-host-chain-for-interchainaccounts
…ainaccounts' into cian/issue#5142-implement-onchanupgradetry-on-host-chain-for-interchainaccounts
…ainaccounts' into cian/issue#5145-implement-onchanupgradeack-on-controller-chain-for-interchainaccounts
…ainaccounts' into cian/issue#5145-implement-onchanupgradeack-on-controller-chain-for-interchainaccounts
@crodriguezvega crodriguezvega added the channel-upgradability Channel upgradability feature label Nov 23, 2023
@charleenfei charleenfei self-assigned this Dec 7, 2023
…r-chain-for-interchainaccounts' of github.com:cosmos/ibc-go into cian/issue#5145-implement-onchanupgradeack-on-controller-chain-for-interchainaccounts
@charleenfei charleenfei marked this pull request as ready for review December 11, 2023 12:41
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one requested change, otherwise lgtm

modules/apps/27-interchain-accounts/types/metadata.go Outdated Show resolved Hide resolved
@charleenfei charleenfei marked this pull request as draft December 11, 2023 13:43
@charleenfei charleenfei marked this pull request as ready for review December 11, 2023 13:59
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charleenfei for pushing this over the line! 🚀 And @chatton for getting this started!

…hanupgradeack-on-controller-chain-for-interchainaccounts
@damiannolan
Copy link
Member

This PR will need type assertions on the UpgradeableModule interface to route callbacks after #5375.

See here for example

If this is merged first I can update my PR.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you again, @chatton and @charleenfei.

charleenfei and others added 2 commits December 12, 2023 10:23
…hanupgradeack-on-controller-chain-for-interchainaccounts
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Merging #5160 (05f7685) into 04-channel-upgrades (8865e29) will decrease coverage by 0.08%.
The diff coverage is 55.31%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           04-channel-upgrades    #5160      +/-   ##
=======================================================
- Coverage                80.45%   80.37%   -0.08%     
=======================================================
  Files                      197      197              
  Lines                    14927    14973      +46     
=======================================================
+ Hits                     12009    12035      +26     
- Misses                    2455     2474      +19     
- Partials                   463      464       +1     
Files Coverage Δ
...interchain-accounts/controller/keeper/handshake.go 84.67% <89.65%> (+1.51%) ⬆️
...7-interchain-accounts/controller/ibc_middleware.go 51.04% <0.00%> (-6.89%) ⬇️

…hanupgradeack-on-controller-chain-for-interchainaccounts
@charleenfei charleenfei marked this pull request as draft December 12, 2023 11:28
@charleenfei charleenfei force-pushed the cian/issue#5145-implement-onchanupgradeack-on-controller-chain-for-interchainaccounts branch from 7b076d1 to 05f7685 Compare December 12, 2023 12:16
@charleenfei charleenfei marked this pull request as ready for review December 12, 2023 12:19
@charleenfei charleenfei merged commit 6718e3c into 04-channel-upgrades Dec 12, 2023
57 checks passed
@charleenfei charleenfei deleted the cian/issue#5145-implement-onchanupgradeack-on-controller-chain-for-interchainaccounts branch December 12, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants