Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Error string in ChanOpenAck #858

Closed
AdityaSripal opened this issue Feb 7, 2022 · 1 comment
Closed

Fix Error string in ChanOpenAck #858

AdityaSripal opened this issue Feb 7, 2022 · 1 comment
Assignees
@colin-axner
Labels
29-fee good first issue Good for newcomers

Comments

@AdityaSripal
Copy link
Member

In OnChanOpenAck, the error message should specify that the expected counterparty fee version is incorrect (expected counterparty version implies the entire version string is being compared)

https://github.com/cosmos/ibc-go/blob/ics29-fee-middleware/modules/apps/29-fee/ibc_module.go#L113
@AdityaSripal AdityaSripal added good first issue Good for newcomers 29-fee labels Feb 7, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Feb 8, 2022
@colin-axner colin-axner self-assigned this Feb 22, 2022
@colin-axner colin-axner mentioned this issue Feb 22, 2022
Merged
9 tasks
@colin-axner
Copy link
Contributor

closed by #971

Repository owner moved this from Backlog to Done in ibc-go Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
29-fee good first issue Good for newcomers
Projects
ibc-go
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AdityaSripal @colin-axner