Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counterparty Address mapping must contain channelID #822

Closed
AdityaSripal opened this issue Feb 1, 2022 · 1 comment
Closed

Counterparty Address mapping must contain channelID #822

AdityaSripal opened this issue Feb 1, 2022 · 1 comment
Assignees
@seantking
Labels
29-fee

Comments

@AdityaSripal
Copy link
Member

AdityaSripal commented Feb 1, 2022 •
edited
Loading

Currently the counterparty address is only a mapping from: <address> -> <counterparty_address>.

However, a relayer will have multiple counterparty addresses for a given address, since their counterparty address will be different for each counterparty chain.

Thus, we must map from (address, channelID) => (counterparty_address).

Action Items:

  • Include ChannelID in MsgRegisterCounterpartyAddress
  • Change the SetCounterpartyAddress and GetCounterpartyAddress to take in a channelID
  • Map Counterparty address to a key that contains tuple: address/channelID

Thanks to @soareschen for pointing out the issue.
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Feb 7, 2022
@seantking seantking self-assigned this Feb 11, 2022
@seantking seantking mentioned this issue Feb 16, 2022
Merged
9 tasks
@seantking seantking moved this from Todo to In review in ibc-go Feb 16, 2022
@colin-axner
Copy link
Contributor

closed by #937

Repository owner moved this from In review to Done in ibc-go Feb 22, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@Manav-Aggarwal
Validate Aggregator hash from the validator set (cosmos#822)
835a470 
When validating the Signed Header in Validate Basic we should check if
the aggregator hash corresponds to the hash of the validator set.

Closes: cosmos#820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seantking seantking

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seantking @AdityaSripal @colin-axner