Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use client and counterparty terminology in packet server rather than channel #7154

Closed
3 tasks
colin-axner opened this issue Aug 13, 2024 · 3 comments
Closed
3 tasks

Use client and counterparty terminology in packet server rather than channel #7154

colin-axner opened this issue Aug 13, 2024 · 3 comments
Assignees
@chandiniv1
Labels
feat: ibc-eureka type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
Eureka alpha

Comments

@colin-axner
Copy link
Contributor

Summary

The packet server for eureka uses channel terminology when it is actually referencing clients. Maybe this will be more useful when channel aliasing is added, but I would recommend renaming ErrChannelNotFound to ErrCounterpartyNotFound and sourceChannel to be sourceClient. The latter may be affected by channel aliasing

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Aug 13, 2024
@colin-axner colin-axner added this to the 05-port refactor alpha milestone Aug 13, 2024
@chandiniv1
Copy link
Contributor

@colin-axner can I work on this issue?

@crodriguezvega
Copy link
Contributor

Hi @chandiniv1. Yes, you can take it. Thank you!

Please use feat/ibc-eureka and the packet server that Colin refers to it's the folder packet-server in core. ErrChannelNotFound is part of 04-channel, so instead of renaming it I would use instead ErrClientNotFound that already exists in 02-client.

@crodriguezvega crodriguezvega removed this from ibc-go Aug 18, 2024
@crodriguezvega crodriguezvega moved this to Todo 🏃 in IBC Eureka Aug 18, 2024
This was referenced Aug 21, 2024
Closed
Merged
@DimitrisJim
Copy link
Contributor

done in #7195

@github-project-automation github-project-automation bot moved this from Todo 🏃 to Done 🥳 in IBC Eureka Aug 26, 2024
@tankcdr tankcdr moved this to Backlog in IBC-GO Eureka Sep 27, 2024
@damiannolan damiannolan moved this from Backlog to Done in IBC-GO Eureka Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chandiniv1 chandiniv1

Labels
feat: ibc-eureka type: code hygiene Clean up code but without changing functionality or interfaces
Projects
IBC Eureka
Archived in project
IBC-GO Eureka
Status: Done
Milestone
Eureka alpha
Development

Successfully merging a pull request may close this issue.

Use client and counterparty terminology in packet server chandiniv1/ibc-go
4 participants
@crodriguezvega @DimitrisJim @colin-axner @chandiniv1