Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Route function on 02-client's Keeper #6011

Closed
2 of 3 tasks
DimitrisJim opened this issue Mar 15, 2024 · 1 comment · Fixed by #6013
Closed
2 of 3 tasks

Add a Route function on 02-client's Keeper #6011

DimitrisJim opened this issue Mar 15, 2024 · 1 comment · Fixed by #6013
Assignees
Labels
02-client needs discussion Issues that need discussion before they can be worked on
Milestone

Comments

@DimitrisJim
Copy link
Contributor

See discussions #5806 (comment) and #5806 (comment).

Can add an additional method on the keeper to directly grab the light client module for a given client id. GetRouter can be kept for cases where we want to directly manipulate the router mapping, most light client code shouldn't directly manipulate that mapping, only access its contents.

Adding needs discussion label just in case, even though there appears to be consensus behind adding it.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added needs discussion Issues that need discussion before they can be worked on 02-client labels Mar 15, 2024
@DimitrisJim DimitrisJim self-assigned this Mar 15, 2024
@DimitrisJim
Copy link
Contributor Author

opened PR for this, as a draft for now. One singular comment to remove the needs discussion will do to move it to open

@crodriguezvega crodriguezvega moved this to Todo 🏃 in ibc-go Mar 17, 2024
@crodriguezvega crodriguezvega moved this from Todo 🏃 to In progress 👷 in ibc-go Mar 17, 2024
@crodriguezvega crodriguezvega added this to the v9.0.0 milestone Mar 17, 2024
@DimitrisJim DimitrisJim moved this from In progress 👷 to In review 👀 in ibc-go Mar 18, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02-client needs discussion Issues that need discussion before they can be worked on
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants