Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move client state testing to light client module entry points #6001

Closed
2 of 7 tasks
damiannolan opened this issue Mar 14, 2024 · 3 comments · Fixed by #6074 or #6135
Closed
2 of 7 tasks

Move client state testing to light client module entry points #6001

damiannolan opened this issue Mar 14, 2024 · 3 comments · Fixed by #6074 or #6135
Assignees
Labels
testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone

Comments

@damiannolan
Copy link
Member

damiannolan commented Mar 14, 2024

Summary

#5806 introduced the light client module interface and its associated implementations within ibc-go.

We should migrate unit tests to use the entrypoints for methods on the light client module. This should increase code coverage.
This can be broken into separate PRs for each client module. Existing tests should be refactored to use the expError error pattern in favour of expPass bool


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels Mar 14, 2024
@damiannolan damiannolan added this to the v9.0.0 milestone Mar 14, 2024
@damiannolan damiannolan moved this to Todo 🏃 in ibc-go Mar 14, 2024
@crodriguezvega
Copy link
Contributor

I am working on the 06-solomachine tests.

@DimitrisJim
Copy link
Contributor

small conflict here, had picked it up yesterday night, synced up async. Picking up solomachine and at least 08-wasm myself atm.

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Apr 3, 2024

think we should just close issue with charly's PR for tendermint and leave a comment on #5959 for localhost tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
Archived in project
4 participants