Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check active channel is CLOSED when reopening an ICA channel #5580

Closed
Tracked by #3996
crodriguezvega opened this issue Jan 11, 2024 · 1 comment
Closed
Tracked by #3996

Check active channel is CLOSED when reopening an ICA channel #5580

crodriguezvega opened this issue Jan 11, 2024 · 1 comment

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Jan 11, 2024

We should check here that the channel is not closed instead, because it could be possible to reopen a channel that is going through an upgrade (in FLUSHING or FLUSH_COMPLETE state).

Thinking now if we should change this condition to channel.State != channeltypes.CLOSED... I am thinking of the following scenario: an ICA channel is going through a channel upgrade and the channel state is either FLUSHING or FLUSH_COMPLETE, and a relayer submits a MsgChannelOpenInit with the same metadata version as the channel going through the upgrade. With the current check the opening handshake would go through, right? I guess we should prevent that?
If we need to change this, we can do it in a follow up PR.

Originally posted by @crodriguezvega in #5562 (comment)

@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jan 11, 2024
@DimitrisJim DimitrisJim self-assigned this Jan 11, 2024
@DimitrisJim DimitrisJim moved this from Todo to In progress in ibc-go Jan 15, 2024
@DimitrisJim DimitrisJim moved this from In progress to In review in ibc-go Jan 15, 2024
@DimitrisJim DimitrisJim moved this from In review to Done in ibc-go Jan 15, 2024
@DimitrisJim
Copy link
Contributor

done in #5601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants