Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow host_connection_id in version metadata to be empty on ChanOpenInit #5437

Closed
3 tasks
srdtrk opened this issue Dec 18, 2023 · 2 comments · Fixed by #5533
Closed
3 tasks

Allow host_connection_id in version metadata to be empty on ChanOpenInit #5437

srdtrk opened this issue Dec 18, 2023 · 2 comments · Fixed by #5533
Assignees
@GNaD13
Labels
27-interchain-accounts change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) nice-to-have

Comments

@srdtrk
Copy link
Member

srdtrk commented Dec 18, 2023

Problem Definition

host_connection_id is not used by the controller. It is also very difficult for a controller contract to obtain the correct value for this parameter on ChanOpenInit (see #3942).

Proposal

We should allow this to be empty at ChanOpenInit and let the icahost fill in the value during version negotiation.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@srdtrk srdtrk added nice-to-have 27-interchain-accounts change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) labels Dec 18, 2023
@srdtrk srdtrk mentioned this issue Dec 18, 2023
Closed
3 tasks
@GNaD13
Copy link
Contributor

GNaD13 commented Dec 24, 2023

Hi @srdtrk, Can i take this issue?

@crodriguezvega
Copy link
Contributor

Hi @srdtrk, Can i take this issue?

Yes, thank you @GNaD13!

@GNaD13 GNaD13 mentioned this issue Jan 7, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GNaD13 GNaD13

Labels
27-interchain-accounts change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) nice-to-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow host_connection_id in version metadata to be empty on ChanOpenInit decentrio/ibc-go
3 participants
@crodriguezvega @srdtrk @GNaD13