You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
UnmarshalPacketData explicitly deserializes packet data from bytes to a concrete type. This logic should be moved to types and other parts of the code can just call this logic in icahost and icacontroller (including UnmarshalPacketData).
Problem Definition
UnmarshalPacketData allows middlewares higher in the stack to request the module to deserialize the packet data. This logic can be used to refactor other parts of the code if it is moved to types. We also have the long term goal of making ModuleCdc private and just expose the serialization and deserialization functions to the public API. We would eventually do this for all apps but we first implement this in interchain accounts.
Proposal
Move UnmarshalPacketData's logic to types.
Refactor other areas of the interchain accounts code to use this function when possible.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
Summary
UnmarshalPacketData
explicitly deserializes packet data from bytes to a concrete type. This logic should be moved to types and other parts of the code can just call this logic in icahost and icacontroller (includingUnmarshalPacketData
).Problem Definition
UnmarshalPacketData
allows middlewares higher in the stack to request the module to deserialize the packet data. This logic can be used to refactor other parts of the code if it is moved to types. We also have the long term goal of making ModuleCdc private and just expose the serialization and deserialization functions to the public API. We would eventually do this for all apps but we first implement this in interchain accounts.Proposal
UnmarshalPacketData
's logic to types.For Admin Use
The text was updated successfully, but these errors were encountered: