Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go.mod for 06-solomachine #4213

Open
3 tasks
colin-axner opened this issue Aug 1, 2023 · 0 comments
Open
3 tasks

Add go.mod for 06-solomachine #4213

colin-axner opened this issue Aug 1, 2023 · 0 comments
Labels
icebox Issues that we will not address for the time being needs discussion Issues that need discussion before they can be worked on nice-to-have

Comments

@colin-axner
Copy link
Contributor

Summary

Give the 06-solomachine its own go.mod and remove ibc-go's dependency on this module.

Problem Definition

06-solomachine is quite naturally a non-circular consumer of the ibc-go API/module, specifically the API defined by 02-client.

Not all chains are users of 06-solomachine and thus do not need to import 06-solomachine or rely on its dependency management.

The coupling of ibc-go with 06-solomachine is not particularly problematic at the moment and thus this issue should not be a priority as there are some issues with giving solomachine its own go.mod

ibc-go uses solomachine in testing:

  • testing certain cases
  • testing package has solomachine code

In order to decouple solomachine, on main improvement is better support for testing light clients in the testing library.

Proposal

Give the 06-solomachine its own go.mod and remove ibc-go's dependency on this module. As stated above, this is low priority and should only be taken up if it is painless to do. Opening as a signaling issue as over time we can begin removing the 06-solomachine dep from ibc-go


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icebox Issues that we will not address for the time being needs discussion Issues that need discussion before they can be worked on nice-to-have
Projects
Status: Backlog 🕐
Development

No branches or pull requests

1 participant