-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GetSignBytes
with Eden upgrade
#3911
Comments
in 0.50 this is automatically inferred based off the proto name, but for backwards compatability we introduced a few proto annotations to recreate the same bytes as before. Amino name annotation: https://github.com/cosmos/cosmos-sdk/blob/b990cb783a25fbcb9c95da570a7918ec29172514/proto/cosmos/auth/v1beta1/auth.proto#L15 We are working on documentation for this as well |
Looks like there is some |
they are not needed anymore |
Indeed! Figured as much, thanks @tac0turtle |
I'm not sure I understand what this documentation is recommending -> https://docs.cosmos.network/v0.50/core/encoding#authz-authorizations-and-govgroup-proposals Should we be doing this amino codec registration on pkg init or is it not required? |
its not needed anymore, we still need to clean up docs for 0.50 |
Summary
GetSignBytes
is being removed as an interface as apart of the Eden SDK upgrade. It can be removed after we have updated to SDK v0.50.xProposal
Remove
GetSignBytes
function from 29-fee msgs and transfer msgs. Please do this pr after the upgrade to SDK v0.50.x has occurred to reduce changes to review in the pr which bumps the SDK versionFor Admin Use
The text was updated successfully, but these errors were encountered: