Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit the app callback handlers for 04-channel upgrades #3757

Closed
3 tasks
damiannolan opened this issue Jun 5, 2023 · 2 comments
Closed
3 tasks

Revisit the app callback handlers for 04-channel upgrades #3757

damiannolan opened this issue Jun 5, 2023 · 2 comments
Assignees
@damiannolan
Labels
04-channel needs discussion Issues that need discussion before they can be worked on
Milestone
04-channel upgrad...

Comments

@damiannolan
Copy link
Member

Summary

Since many changes have taken place wrt channel upgrades spec and implementation we should revisit the app callback handlers defined in 05-port.

See UpgradeModule interface

We should also include informative doc strings to the interface methods.

Some arguments may not be required, adding needs discussion label.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Jun 5, 2023
@damiannolan damiannolan added the needs discussion Issues that need discussion before they can be worked on label Jun 5, 2023
@DimitrisJim
Copy link
Contributor

Also relevant with some additional discussion (linking) #1614

@damiannolan damiannolan mentioned this issue Aug 16, 2023
Merged
9 tasks
@damiannolan damiannolan self-assigned this Aug 24, 2023
@damiannolan
Copy link
Member Author

closing in favour of #1614

@github-project-automation github-project-automation bot moved this to Done in ibc-go Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
04-channel needs discussion Issues that need discussion before they can be worked on
Projects
ibc-go
Status: Done 🥳
Milestone
04-channel upgrades alpha
Development

No branches or pull requests
2 participants
@damiannolan @DimitrisJim