Use a chain config for testing package chain setup #3601
Labels
change: api breaking
Issues or PRs that break Go API (need to be release in a new major version)
needs discussion
Issues that need discussion before they can be worked on
testing
Testing package and unit/integration tests
Milestone
Summary
Add a new
ChainConfig
struct to create custom testing chainsProblem Definition
The testing pkg originally was intended for internal usage, but quickly external developers forked ibc-go to access the testing pkg. It was then redesigned and extended to allow app developer to make use of the package. They can do this by overiding the
DefaultTestingAppInit
variable in the testing package. The intention was that this would only need to be overriden once.With more complex workflows, we see app developers wanting to run the testing pkg against two chains configured with different app.go's. See #3286
Proposal
Create a
ChainConfig
struct:This can then be used in
NewCoordinator
and eventually passed down intoSetupWithGenesisValSet
. This avoids using a global and allows for a cleaner API as theNewCoordinator
call may look like this:For Admin Use
The text was updated successfully, but these errors were encountered: