Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit Tests for Channel Upgrade Event Emission #3497

Closed
3 tasks
chatton opened this issue Apr 20, 2023 · 6 comments · Fixed by #5475
Closed
3 tasks

Add Unit Tests for Channel Upgrade Event Emission #3497

chatton opened this issue Apr 20, 2023 · 6 comments · Fixed by #5475
Assignees
@charleenfei
Labels
04-channel channel-upgradability Channel upgradability feature testing Testing package and unit/integration tests
Milestone
04-channel upgrad...

Comments

@chatton
Copy link
Contributor

chatton commented Apr 20, 2023

Summary

Ref: this comment

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@chatton chatton added this to the 04-channel upgrades alpha milestone Apr 20, 2023
@crodriguezvega crodriguezvega moved this to Todo in ibc-go May 16, 2023
@chatton chatton self-assigned this Jun 27, 2023
@chatton chatton mentioned this issue Jul 5, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega moved this from Todo to In progress in ibc-go Jul 9, 2023
@DimitrisJim
Copy link
Contributor

Guess this can stay open to keep track of ChanUpgradeConfirm? (Or we could just open an additional issue tbh)

@chatton chatton removed their assignment Nov 16, 2023
@chatton
Copy link
Contributor Author

chatton commented Nov 16, 2023

Un-assigning myself for now since the original PR was merged, can leave this issue open until all the events are tested.

@crodriguezvega crodriguezvega moved this from In progress to Todo in ibc-go Nov 20, 2023
@charleenfei
Copy link
Contributor

charleenfei commented Nov 30, 2023 •
edited
Loading

I think the only one left is UpgradeTimeout? can update with this one

@charleenfei charleenfei self-assigned this Nov 30, 2023
@DimitrisJim DimitrisJim mentioned this issue Nov 30, 2023
Merged
9 tasks
@charleenfei
Copy link
Contributor

on hold until this pr is merged

@charleenfei charleenfei moved this from Todo to On hold in ibc-go Nov 30, 2023
@crodriguezvega crodriguezvega moved this from On hold to Todo in ibc-go Dec 7, 2023
@charleenfei charleenfei moved this from Todo to In progress in ibc-go Dec 12, 2023
@colin-axner
Copy link
Contributor

There's commented out tests in TestWriteUpgradeOpenChannel_UnorderedToOrdered()

@colin-axner colin-axner mentioned this issue Dec 20, 2023
Merged
9 tasks
@charleenfei
Copy link
Contributor

Yea, I think all of them need the event testing now after the events were moved, will work on all of them in one go now

@colin-axner colin-axner added testing Testing package and unit/integration tests channel-upgradability Channel upgradability feature labels Dec 20, 2023
@charleenfei charleenfei mentioned this issue Dec 21, 2023
Merged
9 tasks
@charleenfei charleenfei moved this from In progress to In review in ibc-go Jan 5, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleenfei charleenfei

Labels
04-channel channel-upgradability Channel upgradability feature testing Testing package and unit/integration tests
Projects
ibc-go
Archived in project
Milestone
04-channel upgrades RC
Development

Successfully merging a pull request may close this issue.

test: add unit tests for channel upgrade event emission cosmos/ibc-go
5 participants
@crodriguezvega @chatton @DimitrisJim @charleenfei @colin-axner