Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: use cosmos/ics23 v0.9.0 #2863

Closed
crodriguezvega opened this issue Dec 1, 2022 · 6 comments · Fixed by #2868
Closed

deps: use cosmos/ics23 v0.9.0 #2863

crodriguezvega opened this issue Dec 1, 2022 · 6 comments · Fixed by #2868
Assignees
@colin-axner
Labels
dependencies Issues or PRs to update a dependency
Milestone
v6.0.0

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Dec 1, 2022 •
edited
Loading

  • Remove replace tag to ics23 in Cosmos SDK.
  • Backport to v2.4.x, v2.5.x, v3.3.x, v.3.4.x, v4.1.x, v4.2.x, v5.2.x (v5.0.x and v5.1.x will be discontinued when v5.2.0 is released) and v6.0.x.
@crodriguezvega crodriguezvega added the dependencies Issues or PRs to update a dependency label Dec 1, 2022
@colin-axner
Copy link
Contributor

I think we need to verify v0.9.0 is not API breaking for us. The go module name changed

@tac0turtle
Copy link
Member

nothing broke from 0.8 to 0.9. remove the replace tag and after go getting it will work as is. this was the point of 0.9

@colin-axner
Copy link
Contributor

Won't imports change? I believe anyone who calls ibctm.NewClientState(...) will not be able to update to a new version of ibc-go without also changing their code to utilize cosmos/ics23 instead of confio/ics23?

@tac0turtle
Copy link
Member

tac0turtle commented Dec 1, 2022 •
edited
Loading

no its still confio/ics23

@colin-axner
Copy link
Contributor

Ah yea I see now. Nice!

@tac0turtle
Copy link
Member

cosmos/cosmos-sdk#14043

@colin-axner colin-axner mentioned this issue Dec 1, 2022
Merged
9 tasks
@colin-axner colin-axner self-assigned this Dec 1, 2022
@crodriguezvega crodriguezvega moved this to In review in ibc-go Dec 1, 2022
@crodriguezvega crodriguezvega added this to the v6.0.0 milestone Dec 1, 2022
Repository owner moved this from In review to Todo in ibc-go Dec 4, 2022
@damiannolan damiannolan moved this from Todo to Done in ibc-go Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
dependencies Issues or PRs to update a dependency
Projects
ibc-go
Status: Done 🥳
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

chore: bump ics23 to v0.9.0 cosmos/ibc-go
3 participants
@crodriguezvega @tac0turtle @colin-axner