Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solomachine clientID constant to testing package #2843

Closed
3 tasks
colin-axner opened this issue Nov 29, 2022 · 2 comments · Fixed by #3316
Closed
3 tasks

Add solomachine clientID constant to testing package #2843

colin-axner opened this issue Nov 29, 2022 · 2 comments · Fixed by #3316
Assignees
Labels
good first issue Good for newcomers

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Nov 29, 2022

Summary

Add a default clientID used for association of solo machine clients created on a tendermint chain:

diff --git a/testing/values.go b/testing/values.go
index 460e27a23..44af56e8f 100644
--- a/testing/values.go
+++ b/testing/values.go
@@ -18,9 +18,10 @@ import (
 )
 
 const (
-       FirstClientID     = "07-tendermint-0"
-       FirstChannelID    = "channel-0"
-       FirstConnectionID = "connection-0"
+       FirstClientID       = "07-tendermint-0"
+       FirstChannelID      = "channel-0"
+       FirstConnectionID   = "connection-0"
+       SolomachineClientID = "06-solomachine-0"
 
        // Default params constants used to create a TM client
        TrustingPeriod     time.Duration = time.Hour * 24 * 7 * 2

Replace all usage of the "06-solomachine-0" string. See comment

It could make sense to use the name DefaultSolomachineClientID over SolomachineClientID


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@PanGan21
Copy link
Contributor

Hi! Is anyone currently working on this issue? I would like to give it a try :)

@crodriguezvega
Copy link
Contributor

Hi! Is anyone currently working on this issue? I would like to give it a try :)

No, nobody is working on this issue yet, so thanks very much of volunteering! I will assign it to you now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants