-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow localhost enabling to be a parameter #2537
Comments
There already is a parameter in 02-client, closing |
One possible approach:
|
I think in order to do gov v1 message execution it will incur an API breaking change to the ibc core SDK modules which have migrated to use self managed params now take the additional arg to See here and below where the additional |
Could we preemptively get the API breaking change in v7 (without additional logic acting on the authority)? Or does it feel too late in the cycle for that? |
Sounds good to me. I think if its just changing the core |
closing this as #3196 has been merged into the feature branch. |
Perhaps we should add a parameter that allows chains to enable or disable localhost on their chain
This would then be checked in the localhost verification case to ensure it is enabled. Localhost verification should fail if the parameter is set to false
EDIT from @chatton
Additional tasks to be completed after the internal audit:
The text was updated successfully, but these errors were encountered: