Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Params gRPC for 03-connection #2069

Closed
3 tasks
colin-axner opened this issue Aug 22, 2022 · 3 comments · Fixed by #2745
Closed
3 tasks

Add Params gRPC for 03-connection #2069

colin-axner opened this issue Aug 22, 2022 · 3 comments · Fixed by #2745
Assignees
@damiannolan
Labels
03-connection good first issue Good for newcomers
Milestone
SDK v0.47.x upgrade

Comments

@colin-axner
Copy link
Contributor

Summary

Same reasoning as #2066. Should be added for 03-connection params

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner mentioned this issue Aug 22, 2022
Closed
3 tasks
@crodriguezvega crodriguezvega added this to the SDK v0.47.x upgrade milestone Sep 21, 2022
@crodriguezvega
Copy link
Contributor

For reference: #1628 (comment)

@crodriguezvega
Copy link
Contributor

The implementation for transfer can serve as reference. See this comment for details.

@crodriguezvega crodriguezvega added the good first issue Good for newcomers label Oct 10, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Oct 17, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Nov 1, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Nov 9, 2022
@damiannolan damiannolan self-assigned this Nov 14, 2022
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Nov 14, 2022
@damiannolan
Copy link
Member

damiannolan commented Nov 14, 2022 •
edited
Loading

I think we need to go with some alternative naming. e.g. rename the Params grpc in 02-client to ClientParams and use ConnectionParams here.

Otherwise we cause duplicate method: Params compiler errors due to: https://github.com/cosmos/ibc-go/blob/main/modules/core/types/query.go#L15

What do you think?

@damiannolan damiannolan mentioned this issue Nov 14, 2022
Merged
9 tasks
@damiannolan damiannolan moved this from In progress to In review in ibc-go Nov 14, 2022
Repository owner moved this from In review to Todo in ibc-go Nov 17, 2022
@damiannolan damiannolan moved this from Todo to Done in ibc-go Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
03-connection good first issue Good for newcomers
Projects
ibc-go
Status: Done 🥳
Milestone
SDK v0.47.x upgrade
Development

Successfully merging a pull request may close this issue.

feat: adding connection params grpc and cli query cosmos/ibc-go
3 participants
@damiannolan @crodriguezvega @colin-axner