Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Version interface from 03-connection interface types #1690

Closed
1 of 4 tasks
colin-axner opened this issue Jul 12, 2022 · 0 comments · Fixed by #4110
Closed
1 of 4 tasks

Remove Version interface from 03-connection interface types #1690

colin-axner opened this issue Jul 12, 2022 · 0 comments · Fixed by #4110
Labels
03-connection good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Jul 12, 2022

Pre-requirements:

Summary

Remove the Version interface.

Problem Definition

The Version interface was added to fulfill the GetVersions interface. As this function will be removed, this abstraction is no longer necessary and will prevent us from doing unnecessary type casting between the interface and the concrete implementation.

Proposal

  • Remove the Version interface
  • Remove functions casting between the two types
  • Replace all API's with the concrete version type. That is use *Version instead of exported.Version within the version.go file
  • Add changelog entry

There might be some unforseen issue I am overlooking. Please comment if you run into an issue. This change is primarily a code improvement and thus a nice to have


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03-connection good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants