New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nits from first 02-client refactor audit #1581

Closed

5 tasks done

crodriguezvega opened this issue Jun 25, 2022 · 1 comment

Closed

5 tasks done

nits from first 02-client refactor audit #1581

crodriguezvega opened this issue Jun 25, 2022 · 1 comment

Assignees

Labels

Milestone

02-client refacto...

Contributor

crodriguezvega commented Jun 25, 2022 •

edited by chatton

Loading

Move call to SetClientState after call to clientState.Initialize.
Move this line of code + comment into the EmitUpdateClientEvent function.
Move the checkTrustedHeader function to the bottom of the same file.
Panic earlier here instead of using the pruneError auxiliary variable and check later that is not nil.
Rename prevConsState variable to existingConsState.

The text was updated successfully, but these errors were encountered:

crodriguezvega added the 02-client label

crodriguezvega added this to the 02-client refactor RC milestone

seantking assigned chatton

chatton mentioned this issue

chore: making changes based on nits from 02-client refactor audit #1585

Merged

9 tasks

Contributor Author

crodriguezvega commented Jul 7, 2022

Closed by #1585

crodriguezvega closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment