Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmitIncentivizedPacket should emit cumulative fees on a packet #1327

Closed
crodriguezvega opened this issue May 1, 2022 · 1 comment · Fixed by #1391
Closed

EmitIncentivizedPacket should emit cumulative fees on a packet #1327

crodriguezvega opened this issue May 1, 2022 · 1 comment · Fixed by #1391
Assignees
Labels

Comments

@crodriguezvega
Copy link
Contributor

EmitIncentivizedPacket should emit cumulative fees on a packet.

@crodriguezvega crodriguezvega added this to the Fee middleware RC milestone May 1, 2022
@AdityaSripal AdityaSripal added the needs discussion Issues that need discussion before they can be worked on label May 2, 2022
@AdityaSripal
Copy link
Member

I believe this is worth doing since this is the ultimate information that relayers care about. Not the individual increments that are occurring with each escrow.

I expect that most relayers will want to query to find the final balance anyway, so I think we can avoid this by emitting final balances.

The only wrinkle I foresee is a future where the relayer list is non-empty and certain fees are only meant for certain relayers.

In that case, I still think it is worth emitting the cumulative fees intended for permissionless relays (no relayer restriction). And relayers that do have specific fees for them can query the chain to find their alotted fee which will be gte the cumulative permissionless fee. Either way, I think we can solve that UX concern when it arises. For now, we should optimize our current UX which would mean emitting the cumulative fee on each escrow

@crodriguezvega crodriguezvega removed the needs discussion Issues that need discussion before they can be worked on label May 16, 2022
@colin-axner colin-axner self-assigned this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants