Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename result in IncentivizedAcknowledgement #1326

Closed
crodriguezvega opened this issue May 1, 2022 · 0 comments · Fixed by #1338
Closed

Rename result in IncentivizedAcknowledgement #1326

crodriguezvega opened this issue May 1, 2022 · 0 comments · Fixed by #1338
Assignees
@seantking
Labels
29-fee
Milestone
Fee middleware beta

Comments

@crodriguezvega
Copy link
Contributor

Rename result in IncentivizedAcknowledgement to ack or app_acknowledgement or underlying_acknowledgement.
@crodriguezvega crodriguezvega added this to the Fee middleware beta milestone May 1, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go May 1, 2022
@seantking seantking mentioned this issue May 4, 2022
Merged
9 tasks
@seantking seantking self-assigned this May 4, 2022
@seantking seantking moved this from Todo to In review in ibc-go May 4, 2022
Repository owner moved this from In review to Done in ibc-go May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seantking seantking

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware beta
Development

Successfully merging a pull request may close this issue.

refactor: renaming Result in IncentivizedAcknowledgement to AppAcknowledgement cosmos/ibc-go
2 participants
@crodriguezvega @seantking