Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify folder layout for each light client #124

Closed
3 tasks
colin-axner opened this issue Apr 15, 2021 · 3 comments
Closed
3 tasks

Modify folder layout for each light client #124

colin-axner opened this issue Apr 15, 2021 · 3 comments
Assignees
@damiannolan
Labels
needs discussion Issues that need discussion before they can be worked on type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

Remove types/ folder and bring all the files to the top level

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega
Copy link
Contributor

What's the reason for doing this?

If we move the files, this will be API breaking, right?

@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jan 3, 2022
@crodriguezvega crodriguezvega added the type: code hygiene Clean up code but without changing functionality or interfaces label Jan 3, 2022
@colin-axner
Copy link
Contributor Author

code hygiene. The current structure makes no sense. Pretty sure this would be API breaking because the imports would change, but the import changes with every major version bump anyways

faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@alpe
Update contract admin (#124)
9a16d58 
* Add update administrator

* Review comments
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Mar 22, 2022
@crodriguezvega crodriguezvega added this to the 02-client refactor milestone Mar 31, 2022
@crodriguezvega crodriguezvega moved this from Todo to Backlog in ibc-go May 1, 2022
@colin-axner colin-axner moved this from Backlog to Todo in ibc-go May 18, 2022
@seantking seantking added the needs discussion Issues that need discussion before they can be worked on label Jun 27, 2022
@seantking
Copy link
Contributor

Flagged as needs discussion during planning session as we agreed preliminarily that this is potentially unnecessary.

@seantking seantking moved this from Todo to On hold in ibc-go Jun 27, 2022
This was referenced Jul 8, 2022
Merged
Merged
@damiannolan damiannolan self-assigned this Jul 8, 2022
@damiannolan damiannolan moved this from On hold to In review in ibc-go Jul 8, 2022
Repository owner moved this from In review to Done in ibc-go Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
needs discussion Issues that need discussion before they can be worked on type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
02-client refactor beta
Development

No branches or pull requests
4 participants
@damiannolan @crodriguezvega @seantking @colin-axner