From 74d9450f746bee1d0894d5e2ef13d9b83ae6c98b Mon Sep 17 00:00:00 2001
From: Damian Nolan <damiannolan@gmail.com>
Date: Wed, 2 Feb 2022 14:05:29 +0100
Subject: [PATCH] test: adding ica test for multiple controllers, single host
 (#816)

* adding test for multiple controllers, single host

* updating inline comments

* updating todos with correct ports

* reorder to use pathCToB.Endpoint for connection IDs

(cherry picked from commit 83c3e4160ba0399e04397ddf09f42a73259d7f56)
---
 .../controller/ibc_module_test.go             | 70 ++++++++++++++++++-
 1 file changed, 69 insertions(+), 1 deletion(-)

diff --git a/modules/apps/27-interchain-accounts/controller/ibc_module_test.go b/modules/apps/27-interchain-accounts/controller/ibc_module_test.go
index ca1b0db6b06..9fd7486cf1a 100644
--- a/modules/apps/27-interchain-accounts/controller/ibc_module_test.go
+++ b/modules/apps/27-interchain-accounts/controller/ibc_module_test.go
@@ -46,6 +46,7 @@ type InterchainAccountsTestSuite struct {
 	// testing chains used for convenience and readability
 	chainA *ibctesting.TestChain
 	chainB *ibctesting.TestChain
+	chainC *ibctesting.TestChain
 }
 
 func TestICATestSuite(t *testing.T) {
@@ -53,9 +54,10 @@ func TestICATestSuite(t *testing.T) {
 }
 
 func (suite *InterchainAccountsTestSuite) SetupTest() {
-	suite.coordinator = ibctesting.NewCoordinator(suite.T(), 2)
+	suite.coordinator = ibctesting.NewCoordinator(suite.T(), 3)
 	suite.chainA = suite.coordinator.GetChain(ibctesting.GetChainID(1))
 	suite.chainB = suite.coordinator.GetChain(ibctesting.GetChainID(2))
+	suite.chainC = suite.coordinator.GetChain(ibctesting.GetChainID(3))
 }
 
 func NewICAPath(chainA, chainB *ibctesting.TestChain) *ibctesting.Path {
@@ -89,6 +91,7 @@ func RegisterInterchainAccount(endpoint *ibctesting.Endpoint, owner string) erro
 	// update port/channel ids
 	endpoint.ChannelID = channeltypes.FormatChannelIdentifier(channelSequence)
 	endpoint.ChannelConfig.PortID = portID
+	endpoint.ChannelConfig.Version = TestVersion
 
 	return nil
 }
@@ -632,3 +635,68 @@ func (suite *InterchainAccountsTestSuite) TestOnTimeoutPacket() {
 		})
 	}
 }
+
+func (suite *InterchainAccountsTestSuite) TestSingleHostMultipleControllers() {
+	var (
+		pathAToB *ibctesting.Path
+		pathCToB *ibctesting.Path
+	)
+
+	testCases := []struct {
+		msg      string
+		malleate func()
+		expPass  bool
+	}{
+		{
+			"success",
+			func() {},
+			true,
+		},
+	}
+
+	for _, tc := range testCases {
+		suite.Run(tc.msg, func() {
+			suite.SetupTest() // reset
+
+			// Setup a new path from A(controller) -> B(host)
+			pathAToB = NewICAPath(suite.chainA, suite.chainB)
+			suite.coordinator.SetupConnections(pathAToB)
+
+			err := SetupICAPath(pathAToB, TestOwnerAddress)
+			suite.Require().NoError(err)
+
+			// Setup a new path from C(controller) -> B(host)
+			pathCToB = NewICAPath(suite.chainC, suite.chainB)
+			suite.coordinator.SetupConnections(pathCToB)
+
+			// NOTE: Here the version metadata is overridden to include to the next host connection sequence (i.e. chainB's connection to chainC)
+			// SetupICAPath() will set endpoint.ChannelConfig.Version to TestVersion
+			TestVersion = string(icatypes.ModuleCdc.MustMarshalJSON(&icatypes.Metadata{
+				Version:                icatypes.Version,
+				ControllerConnectionId: pathCToB.EndpointA.ConnectionID,
+				HostConnectionId:       pathCToB.EndpointB.ConnectionID,
+			}))
+
+			err = SetupICAPath(pathCToB, TestOwnerAddress)
+			suite.Require().NoError(err)
+
+			tc.malleate() // malleate mutates test data
+
+			accAddressChainA, found := suite.chainB.GetSimApp().ICAHostKeeper.GetInterchainAccountAddress(suite.chainB.GetContext(), pathAToB.EndpointB.ConnectionID, pathAToB.EndpointA.ChannelConfig.PortID)
+			suite.Require().True(found)
+
+			accAddressChainC, found := suite.chainB.GetSimApp().ICAHostKeeper.GetInterchainAccountAddress(suite.chainB.GetContext(), pathCToB.EndpointB.ConnectionID, pathCToB.EndpointA.ChannelConfig.PortID)
+			suite.Require().True(found)
+
+			suite.Require().NotEqual(accAddressChainA, accAddressChainC)
+
+			chainAChannelID, found := suite.chainB.GetSimApp().ICAHostKeeper.GetActiveChannelID(suite.chainB.GetContext(), pathAToB.EndpointB.ConnectionID, pathAToB.EndpointA.ChannelConfig.PortID)
+			suite.Require().True(found)
+
+			chainCChannelID, found := suite.chainB.GetSimApp().ICAHostKeeper.GetActiveChannelID(suite.chainB.GetContext(), pathCToB.EndpointB.ConnectionID, pathCToB.EndpointA.ChannelConfig.PortID)
+			suite.Require().True(found)
+
+			suite.Require().NotEqual(chainAChannelID, chainCChannelID)
+		})
+	}
+}