diff --git a/e2e/tests/core/02-client/client_test.go b/e2e/tests/core/02-client/client_test.go index 6deb6cdcfbc..e3725fc9c73 100644 --- a/e2e/tests/core/02-client/client_test.go +++ b/e2e/tests/core/02-client/client_test.go @@ -52,18 +52,6 @@ type ClientTestSuite struct { testsuite.E2ETestSuite } -// Status queries the current status of the client -func (s *ClientTestSuite) Status(ctx context.Context, chain ibc.Chain, clientID string) (string, error) { - res, err := query.GRPCQuery[clienttypes.QueryClientStatusResponse](ctx, chain, &clienttypes.QueryClientStatusRequest{ - ClientId: clientID, - }) - if err != nil { - return "", err - } - - return res.Status, nil -} - // QueryAllowedClients queries the on-chain AllowedClients parameter for 02-client func (s *ClientTestSuite) QueryAllowedClients(ctx context.Context, chain ibc.Chain) []string { res, err := query.GRPCQuery[clienttypes.QueryClientParamsResponse](ctx, chain, &clienttypes.QueryClientParamsRequest{}) @@ -217,13 +205,13 @@ func (s *ClientTestSuite) TestClientUpdateProposal_Succeeds() { t.Run("check status of each client", func(t *testing.T) { t.Run("substitute should be active", func(t *testing.T) { - status, err := s.Status(ctx, chainA, substituteClientID) + status, err := query.ClientStatus(ctx, chainA, substituteClientID) s.Require().NoError(err) s.Require().Equal(ibcexported.Active.String(), status) }) t.Run("subject should be expired", func(t *testing.T) { - status, err := s.Status(ctx, chainA, subjectClientID) + status, err := query.ClientStatus(ctx, chainA, subjectClientID) s.Require().NoError(err) s.Require().Equal(ibcexported.Expired.String(), status) }) @@ -236,13 +224,13 @@ func (s *ClientTestSuite) TestClientUpdateProposal_Succeeds() { t.Run("check status of each client", func(t *testing.T) { t.Run("substitute should be active", func(t *testing.T) { - status, err := s.Status(ctx, chainA, substituteClientID) + status, err := query.ClientStatus(ctx, chainA, substituteClientID) s.Require().NoError(err) s.Require().Equal(ibcexported.Active.String(), status) }) t.Run("subject should be active", func(t *testing.T) { - status, err := s.Status(ctx, chainA, subjectClientID) + status, err := query.ClientStatus(ctx, chainA, subjectClientID) s.Require().NoError(err) s.Require().Equal(ibcexported.Active.String(), status) }) @@ -300,13 +288,13 @@ func (s *ClientTestSuite) TestRecoverClient_Succeeds() { t.Run("check status of each client", func(t *testing.T) { t.Run("substitute should be active", func(t *testing.T) { - status, err := s.Status(ctx, chainA, substituteClientID) + status, err := query.ClientStatus(ctx, chainA, substituteClientID) s.Require().NoError(err) s.Require().Equal(ibcexported.Active.String(), status) }) t.Run("subject should be expired", func(t *testing.T) { - status, err := s.Status(ctx, chainA, subjectClientID) + status, err := query.ClientStatus(ctx, chainA, subjectClientID) s.Require().NoError(err) s.Require().Equal(ibcexported.Expired.String(), status) }) @@ -322,13 +310,13 @@ func (s *ClientTestSuite) TestRecoverClient_Succeeds() { t.Run("check status of each client", func(t *testing.T) { t.Run("substitute should be active", func(t *testing.T) { - status, err := s.Status(ctx, chainA, substituteClientID) + status, err := query.ClientStatus(ctx, chainA, substituteClientID) s.Require().NoError(err) s.Require().Equal(ibcexported.Active.String(), status) }) t.Run("subject should be active", func(t *testing.T) { - status, err := s.Status(ctx, chainA, subjectClientID) + status, err := query.ClientStatus(ctx, chainA, subjectClientID) s.Require().NoError(err) s.Require().Equal(ibcexported.Active.String(), status) }) diff --git a/e2e/tests/core/03-connection/connection_test.go b/e2e/tests/core/03-connection/connection_test.go index 59140da51f8..e9a8cab12ad 100644 --- a/e2e/tests/core/03-connection/connection_test.go +++ b/e2e/tests/core/03-connection/connection_test.go @@ -45,6 +45,7 @@ func (s *ConnectionTestSuite) QueryMaxExpectedTimePerBlockParam(ctx context.Cont Subspace: ibcexported.ModuleName, Key: string(connectiontypes.KeyMaxExpectedTimePerBlock), }) + s.Require().NoError(err) // removing additional strings that are used for amino delay := strings.ReplaceAll(res.Param.Value, "\"", "") diff --git a/e2e/tests/upgrades/upgrade_test.go b/e2e/tests/upgrades/upgrade_test.go index 1f740973f84..7877cff08dd 100644 --- a/e2e/tests/upgrades/upgrade_test.go +++ b/e2e/tests/upgrades/upgrade_test.go @@ -996,7 +996,7 @@ func (s *UpgradeTestSuite) TestV8ToV8_1ChainUpgrade_ChannelUpgrades() { } // ClientState queries the current ClientState by clientID -func (s *UpgradeTestSuite) ClientState(ctx context.Context, chain ibc.Chain, clientID string) (*clienttypes.QueryClientStateResponse, error) { +func (*UpgradeTestSuite) ClientState(ctx context.Context, chain ibc.Chain, clientID string) (*clienttypes.QueryClientStateResponse, error) { res, err := query.GRPCQuery[clienttypes.QueryClientStateResponse](ctx, chain, &clienttypes.QueryClientStateRequest{ClientId: clientID}) if err != nil { return res, err