update Gaia with to latest SDK master #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
fedekunze
commented
Dec 4, 2019
| ) | ||
|
|
||
| // SimulationOperations retrieves the simulation params from the provided file path | ||
| // and returns all the modules weighted operations | ||
| func SimulationOperations(app *GaiaApp, cdc *codec.Codec, config simulation.Config) []simulation.WeightedOperation { |
There was a problem hiding this comment.
simapp.SimulationOperations receives a SimApp as parameter, so I can't use that util func atm. I'd need to extend Simapp to return the simulation manager (app.sm) and use a general App interface.
There was a problem hiding this comment.
I'd like to do that in a separate PR on the SDK tho
There was a problem hiding this comment.
will open an issue on SDK
fedekunze
changed the title
alessio
approved these changes
Dec 5, 2019
|
All sims passing! 🎉🕺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated Gaia with the simulation refactors from cosmos/cosmos-sdk#4869
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)