This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Allow networkId as a parameter #324
Closed
+1,819
−964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables us to run 'make test_integrations' which tests our changes against a live ethermint network, where web3 tests are run. This ensure that nothing accidentally breaks the functionality of ethereum while still passing all the ordinary go tests. 'make test_integrations' spins up docker containers to form a live network of communicating ethermint nodes. Then it runs all integration tests against this live network and reports back the results. There should not be any side effects to the functionality of ethermint.
* linting: address some checks * add nolint warnings; remove duplicate megacheck from Makefile * add metalinter to CI, closes cosmos#196 * Run metalinter on travis * metalinter: don't run on CI yet
This document explains the ideal Ethermint architecture. The current design is similar but less modular. From this starting point, we will start an incremental refactor until we are at this design. The design itself is not perfect and will change over time. By splitting Ethermint up this way, we have the ability to add custom RPC endpoints. This allows the addition of special IBC endpoints which will be needed for IBC. This adds a description of a light client for ethermint which leverages the properties of tendermint to provide a fully secure EVM light client. A light client can keep of with the state and doesn't have to trust a single node. Furthermore, it can submit transactions. I've added a paragraph that explains how accounts are managed by an ethermint instance. This is the last missing piece as now ethermint provides all the functionality in a coherent way that we need it to. * Extend architecture with IBC and Rewards * Reason why we need this redesign * Explanation for accounts * Add time estimate * Simplify future design * More IBC explanations * Light client explanation
docs: fix typo of the name of the project
docs: rst format fixes
* ibc * docs: add a link * docs: small improvements to intro * docs: add install.rst to getting-started
* Add stateful checkTx * Tests for stateful checktx * Mirror validateTx logic from tx_pool.go. Move checkTxState updates * Move transaction size limit into const. Remove uneeded fmt import * Enable nonces to be strictly increasing * Extract all directory setup into functional style tests This change removes the duplicated code to setup temporary directories for each test. Now all code is grouped in the setupTestCase() function instead of being littered around all the test cases. There are no side effects of this. * Refactor app_test.go to remove the duplicated code The tests where getting unwieldy since they duplicated a lot of code. With the new setup it is much easier to create new test cases, since the setup and tear-down are handled nicely. There are no side effects. * Add test case for non-incremental nonces This test case checks that transactions have to have strictly increasing nonces. It tests by sending a transaction with nonce 0, and then tries to send a transaction with nonce 2. The second transaction should fail, since it is not strictly increasing. Some of the error descriptions have changed, but no one should be matching for a specific error string. * Refactor tests and RPC library This change is the last refactor of the app_tests and was needed for clarity. Also, it upgrades everything to use a typed RPC client instead of passing strings to get to raw endpoints. * Add check whether it's contract creation * Update Changelog Signed-off-by: Adrian Brink <[email protected]>
* docs: deduplicate files & harmonize presentation * docs: do lists properly & other nits
* linter: run it during CI * Break import cycle in ethereum package * Disable all linters and enable only unused
allow setting network id
|
|
|
metamask will be focusing on more flexible node configurations + multichain support after devcon |
|
Moved to #345 |
|
@kumavis That's great to hear :-) |
i-norden
pushed a commit
to vulcanize/old_ethermint
that referenced
this pull request
Aug 31, 2020
* bump SDK commit * crypto: Secp256k1 algorithm * crypto: fix codec and derivation issues * lint
i-norden
pushed a commit
to vulcanize/old_ethermint
that referenced
this pull request
Aug 31, 2020
This reverts commit 5614adc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
Related to #81
Metamask was not taking in consideration networkId until recent updates. Its related to EIP ethereum/EIPs#155 & MetaMask/metamask-extension#1722 (comment)