From 5920a3d0748f48c3d449f039d5b4658ee24d3ff8 Mon Sep 17 00:00:00 2001 From: Aditya Sripal Date: Tue, 6 Jul 2021 14:46:25 +0200 Subject: [PATCH 1/3] fix event type --- x/ibc/applications/transfer/module.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x/ibc/applications/transfer/module.go b/x/ibc/applications/transfer/module.go index f0d8aa2cb5c6..79de4e77b4cf 100644 --- a/x/ibc/applications/transfer/module.go +++ b/x/ibc/applications/transfer/module.go @@ -343,7 +343,7 @@ func (am AppModule) OnRecvPacket( sdk.NewAttribute(types.AttributeKeyReceiver, data.Receiver), sdk.NewAttribute(types.AttributeKeyDenom, data.Denom), sdk.NewAttribute(types.AttributeKeyAmount, fmt.Sprintf("%d", data.Amount)), - sdk.NewAttribute(types.AttributeKeyAckSuccess, fmt.Sprintf("%t", err != nil)), + sdk.NewAttribute(types.AttributeKeyAckSuccess, fmt.Sprintf("%t", err == nil)), ), ) From f7c52dbe5b25be95771a50c00dcf03be28d941f2 Mon Sep 17 00:00:00 2001 From: Aditya Sripal Date: Wed, 7 Jul 2021 16:13:11 +0200 Subject: [PATCH 2/3] CHANGELOG --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 230d696915e7..9b2cfd7cc146 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,6 +34,12 @@ Ref: https://keepachangelog.com/en/1.0.0/ # Changelog +## Unreleased + +### Bug Fixes + +* (x/ibc) [\#9640](https://github.com/cosmos/cosmos-sdk/pull/9640#pullrequestreview-699914607) Fix IBC Transfer Ack Success event as it was initially emitting opposite value. + ## [v0.42.6](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.42.6) - 2021-06-18 ### Improvements From 028f6cf817358dc25a9774c15d245fdbb780ec38 Mon Sep 17 00:00:00 2001 From: Amaury <1293565+amaurym@users.noreply.github.com> Date: Fri, 9 Jul 2021 11:15:02 +0200 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9b29913e794a..8828b507cf2e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -43,7 +43,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ ### Bug Fixes -* (x/ibc) [\#9640](https://github.com/cosmos/cosmos-sdk/pull/9640#pullrequestreview-699914607) Fix IBC Transfer Ack Success event as it was initially emitting opposite value. +* (x/ibc) [\#9640](https://github.com/cosmos/cosmos-sdk/pull/9640) Fix IBC Transfer Ack Success event as it was initially emitting opposite value. * [\#9645](https://github.com/cosmos/cosmos-sdk/pull/9645) Use correct Prometheus format for metric labels. * [\#9299](https://github.com/cosmos/cosmos-sdk/pull/9299) Fix `[appd] keys parse cosmos1...` freezing.