fix REST endpoints in migration docs #8648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleem1314
requested review from
aaronc,
alessio and
alexanderbez
as code owners
amaury1093
approved these changes
Feb 22, 2021
|
thanks @aleem1314 for auditing these links! Do you think we can add #8657 too? |
amaury1093
reviewed
Feb 22, 2021
docs/migrations/rest.md
Outdated
| | `GET /distribution/validators/{validatorAddr}` | Validator distribution information | `GET /cosmos/distribution/v1beta1/validators/{validatorAddr}` | | ||
| | `GET /distribution/validators/{validatorAddr}/rewards` | Commission and self-delegation rewards of a single a validator | `GET /cosmos/distribution/v1beta1/validators/{validatorAddr}/rewards` | | ||
| | `GET /distribution/validators/{validatorAddr}` | Validator distribution information | N/A | | ||
| | `GET /distribution/validators/{validatorAddr}/rewards` | Commission and self-delegation rewards of a single a validator | N/A | |
There was a problem hiding this comment.
Could that be replaced with ValidatorOutstandingRewards and ValidatorCommission?
…osmos/cosmos-sdk into aleem/8599-rest-migration-docs
anilcse
approved these changes
Feb 24, 2021
amaury1093
added
the
A:automerge
mergify bot
pushed a commit
that referenced
this pull request
Feb 24, 2021
* fix endpoints * update docs * fix routes * update docs Co-authored-by: Anil Kumar Kammari <[email protected]> (cherry picked from commit 897f20b) # Conflicts: # docs/migrations/rest.md
alessio
pushed a commit
that referenced
this pull request
Feb 26, 2021
Co-authored-by: Anil Kumar Kammari <[email protected]> (cherry picked from commit 897f20b) Co-authored-by: MD Aleem <[email protected]> Co-authored-by: Marko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #8599
closes: #8657
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes