Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update baseapp docs #8630

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Update baseapp docs #8630

merged 3 commits into from
Feb 19, 2021

Conversation

colin-axner
Copy link
Contributor

Description

I got a little thrown off reading this. I think this is clearer

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner colin-axner added the T:Docs Changes and features related to documentation. label Feb 18, 2021
docs/core/baseapp.md Outdated Show resolved Hide resolved
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 19, 2021
@mergify mergify bot merged commit ceeb2a0 into master Feb 19, 2021
@mergify mergify bot deleted the colin/docs branch February 19, 2021 15:07
mergify bot pushed a commit that referenced this pull request Feb 19, 2021
* update docs

* Update docs/core/baseapp.md

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit ceeb2a0)
alessio pushed a commit that referenced this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants